union node validation ensures upstream attributes match Union node name #135
Conversation
Signed-off-by: Jesus Rocha <[email protected]>
|
Upstream RevenueOfDivision1 has attribute Attempting to run the flow at the Union will yield the following message to guide alignment of attributes to union name Error above is due to |
| return { | ||
| isValid: false, | ||
| error: | ||
| 'The Union upstream nodes require attribute to be equal to Union name', |
There was a problem hiding this comment.
@JesusGuerrero could this error message be made more explicit/detailed? Something like:
`The Union upstream nodes require attribute to be equal to the Union name. Currently, upstream node X has attributes named A, B and C; upstream node Y has attributes Z and ...". All these nodes should have an attribute called "
There was a problem hiding this comment.
And this actually introduces a problem because now it is not possible for a node to participate in two union nodes. It's OK for now, but we need to work on #70 to fully address the issue consistently.
Signed-off-by: Jesus Rocha [email protected]