-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent treatment of attributes #70
Labels
Comments
Open
15 tasks
@laurachiticariu Thank you for writing up all these examples / explanations! I have a couple questions:
When you say "the input node" - should this node type only have one input node? Or should I combine the attributes of all input nodes?
Could you explain what the "primary input node" is? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently attributes are allowed to be renamed and turned off on the Sequence node. We should enable this for all nodes.
Here is the desired behavior.
Dictionary (Mapped terms = OFF) and Literal:
Dictionary (Map terms = ON)
Mapped Term
by defaultRegex:
\$(\d+(\.\d+)?)\s+(billion)
that captures text such as$3.4 billion
should have 4 attributes by default:$3.4 billion
3.4
.4
billion
Sequence:
(<Metric.Metric>)<Token>{0,1}(<Preposition.Preposition>)<Token>{0,2}(<Division.Division>)
that captures text such asrevenue from the Global Technology Services
should have 4 attributes by default (one for the entire match, and one for each open parenthesis):revenue from the Global Technology Services
revenue
from
Global Technology Services
(<Metric.Metric><Token>{0,1}<Preposition.Preposition>)<Token>{0,2}(<Division.Division>)
that captures text such asrevenue from the Global Technology Services
should have 3 attributes by default (one for the entire match, and one for each open parenthesis - 2 of them):revenue from the Global Technology Services
revenue from
Global Technology Services
Union
Consolidate
Filter
The text was updated successfully, but these errors were encountered: