Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 5- Ryan Tong #3

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ryanryantong
Copy link

@ryanryantong ryanryantong commented Nov 2, 2022

Was not able to fully debug cluster. Not sure what is wrong, tried many different fixes to no success. My thoughts on what could possibly be wrong:

  • Zstride is way too big but should be calculated correctly (far- near) / zSlices. The camera far value is way to big and makes z always 0. Not sure if this is desired
  • Projecting to camera space makes z values negative but sometimes positive. Multiplying by -1 still means sometimes there is a negative z meaning that my width/height values are negative possibly messing up floor and min stuff. Not sure if this is desired
  • Me not understanding the projection math

Features implemented

  • somewhat working clustering
  • cluster deferred
  • blinn phong

Optimization not implemented but discussed in readme
2 late days used

Comments on this hw:
I thought this hw was a bit too time consuming and irrelevant considering final projects are coming up. Learning js combined with a revisiting shading pipelines from CIS460 was very time consuming especially for a non-graphics student. Also, I would have preferred and third option (ML) because both choices were irrelevant to my final project but I know that is a lot to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant