Addresses #823, #824 -- navigation menus and aria hidden #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… forever. It goes away by clicking outside it, tabbing out of it, pressing escape.
…to be hidden from screen readers (such as some visual button elements such as font-awesome that can be ignored because of redundant text)
…outside, esc) and closes if navigating out of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #823, #824 -- navigation menus and aria hidden
The login form that opened up had a similar problem to the menu that was hard to dismiss and it also reloaded the page when trying to close, so fixed that, also.
I also added to the gulp build so that Javascript is updated after modified and rebuilt. Before you had to copy to the correct place manually, which I didn't see the point of and this makes modifying and testing much easier than taking so many steps manually every time.