Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating all gem and js dependencies for the main branch #630

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

briri
Copy link
Collaborator

@briri briri commented Jul 11, 2024

Just updating the main branch for all gem and JS dependencies to address Dependabot alerts

Copy link

1 Warning
⚠️ This PR is too big! Consider breaking it down into smaller PRs.

Generated by 🚫 Danger

@jupiter007
Copy link
Collaborator

@briri , I ran the command "npm audit fix --force", and noticed that it updated "puppeteer" to "^22.13.0" and tinymce version to "^7.2.1". I looked those packages up, and it does appear that the versions we are using now have some vulnerabilities. Also, "pa11y" and "pa11y-ci" versions were updated.

I know that we are not using the main branch, but I figured while you're in there we could also make those updates.

@briri
Copy link
Collaborator Author

briri commented Jul 11, 2024

ok agreed.
I updated TinyMCE and Puppeteer and then I removed the devDependencies. They're not used

  • Jasmine and Mocha, there were only a few JS tests in the Rails (not React) code and they are never run
  • ESLint we don't run it against the Rails JS app/javascript
  • Pa11y we don't really use it anymore. It only checked the public facing pages and we had a thorough accessibility test for those pages with UCOP

I ran yarn audit and it is happy now

@jupiter007
Copy link
Collaborator

Thanks Brian

@briri briri merged commit 8030f45 into main Jul 11, 2024
3 of 10 checks passed
@briri briri deleted the update-dependencies branch July 11, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants