forked from DMPRoadmap/roadmap
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React prototype #525
Merged
Merged
React prototype #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oard with a small form to allow DMP IDs to receive simulated related work content
…E-react-prototype
- Project search should not be available if the funder doesn't have an api - Started adding correct statuses starting with contributors - Various requested changes and bugfixes discovered while working on above
fixed related bugs discovered while working on this.
…stamps to JSON of draft DMP
…t been done. fixed issue with PDF publisher job
... added this to out handleResponse method. This way we can deal with the error and have access to the actual response that was received.
…s defaults set for registration
… Drafts that have a null DraftId
…menu. added link to participating orgs. renamed React Dashboard to 'Uploads'
…to the plans table
…promote the dmptool page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
There is a lot here. Please read through everything and note that the following need to be run as part of the deployment:
rails db:migrate
rails v5:upgrade_5_0
which will add API info to theregistry_orgs
records for NIH, NSF, NASA orgs and some that have grant ids in Crossref as wellrails v5:enable_v5_pilot
with the names of the Orgs you want to be a part of the React prototype pilotwhich will move existing DMP IDs from the
identifierstable to the
plans.dmp_id` fieldrails v5:build_narratives
to rebuild all of the existing public plans PDF files and store them in ActiveStoragerails v5:seed_dmphub
to seed the new DMPHub system with your DMP IDs (if you use the DMPHub and are transitioning to the new system)Updated Terms of Use
v4 Cleanup
repositories.custom_repository_owner_template_id
research_outputs.output_type
research_outputs.output_type_description
ActiveStorage for Public DMPs:
aws-sdk-s3
andactive_storage_validations
PlanExportsController
so that it will serve up a copy of a public plan's PDF from the designated S3 bucket when the requestor is not logged in (prevents bots that crawl the site from bogging down the server)narrative
to thePlan
model which stores PDF narratives for public plans.config/environments/*.rb
to use S3 for ActiveStorage (or local disk for development)config/storage.rb
to define S3 bucketAdded Delayed Job
delayed_jobs
tabledelayed_job_active_record
anddaemons
subscriber_job_status
andpublisher_job_status
toplans
anddrafts
tables.delayed_job
anddaemons
gems so that some of the longer running processes that connect to external content do not bog down the system.CitationJob
to fetch DOI citations asynchronouslyNotifySubscriberJob
to work with the new delayed_job frameworkOrcidPublisher
job to make that piece of DMP registration asyncPdfPublisher
job that will send the PDF narrative document to the DMPHub asynchronouslyReact DMP Upload Prototype:
plans.dmp_id
to begin storing the DMP ID directly in the plans tableregistry_orgs
table to store information about how to connect to their external APIsrelated_identifiers
type calledoutput_management_plan
orgs.v5_pilot
boolean field that determines whether or not the user can access the new React prototype pages (user must also be an org admin)dmphub_auth_url
configuration item to theconfig/dmproadmap.yml
fileconfig/initializers/cors.rb
to support external commsrack-cors
andtext
drafts
table to store unregistered "in progress" DMPs created by the new React dashboardhidden_dmps
table to support user's indicating that they do not want to see a registered DMP on their dashboardreact-client
directory in the project root/api/v3/me
returns the currently logged in user's name and email/api/v3/contributor_roles
returns the list of valid contributor roles/api/v3/output_types
returns the list of valid research output types/api/v3/related_work_types
returns the list of valid related work types/api/v3/affiliations
provides search/typeahead support for affiliation form fields/api/v3/funders
provides search/typeahead support for funder form fields/api/v3/repositories
provides search/typeahead support for repository form fields/api/v3/awards/nih
endpoint used to search the NIH API for projects/api/v3/awards/nsf
endpoint used to search the NSF and NASA API for projects/api/v3/awards/crossref/*fundref_id
endpoint used to search the Crossref Grants API (DOE, etc.) for projects/api/v3/simulations
endpoint which is used to simulate the discovery (by external systems) of related works/api/v3/citations
endpoint to retrieve BibTex citations for a given DOI/api/v3/drafts
Full REST support for creating/updating/deleting Draft DMPs (aka DMPs that have not been registered)/api/v3/dmps
Full REST support for creating/updating Registered DMPs (aka ones with a DMP ID)Org_Selectable
controller concern to work with new React Org typeaheadPlan
andDraft
to be sent to the DMPHub for registration/updates.DashboardsController
that serves up the React contentPlansController
to use the newRegistrable
model concerndmp_id_for_display
to theDmptoolHelper
IdentifierHelper
to work with the newRegistrable
model concernreact-application
JS asset so that the React pages get a more compact JS file than the standard Rails oneRegisterable
model concern and included it on thePlan
and newDraft
models. This involved moving some of the functionality that was on thePlan
model to the new concern.User
model to havedrafts
(used exclusively by the React prototype) andhidden_dmps
for when a user opts to no longer see a registered DMP on their React dashboardPlan
children (e.g.Contributor
andAnswer
) to call theNotifySubscriberJob
Presenters
andViews
to work these changes