Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference UUID from the originally created test event when generating FHIR bundle for corrections #8084

Closed
fzhao99 opened this issue Aug 29, 2024 · 1 comment · Fixed by #8207
Assignees
Labels
ReportStream Issues stemming from ReportStream feedback

Comments

@fzhao99
Copy link
Contributor

fzhao99 commented Aug 29, 2024

Description

In a recent RS meeting, James mentioned that for FHIR messages corresponding to corrected test events, we're making a new UUID for the diagnosticReport.identifier.value field. We should reference the UUID for the original test event instead.

Proposed solution

In this part of the FHIR converter, we need to pass in the original test event ID in the event that something is a correction. This might need to be done further up in the conversion step in the event that we're using the UUID of the test event in multiple places. In other words, check that in cases where we use the original test event ID that it's replaced globally and not just in this part of the converted bundle.

Additional context

Check with James that once this fix goes through the UUID association works for the correction flow (ie submit a correction and have them check that the FHIR bundle they get refers back to the original)

@fzhao99 fzhao99 added Needs refinement ReportStream Issues stemming from ReportStream feedback labels Aug 29, 2024
@DanielSass
Copy link
Collaborator

Do we need to change other places where we use the test event id to point to the old id as well? Possibly a question for James

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReportStream Issues stemming from ReportStream feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants