Load only monthly service invoices when loading from S3 #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naved001
requested changes
Dec 17, 2025
process_report/loader.py
Outdated
| s3_name = os.path.join( | ||
| invoice_settings.invoice_path_template, | ||
| local_name, | ||
| ).format(invoice_month=invoice_settings.invoice_month) |
Collaborator
There was a problem hiding this comment.
This particular use of os.path.join will produce the desired S3 key, despite that it's still not a good use of os.path.join because S3 Keys are not OS paths. This communicates wrong intent in my opinion. I'd rather we just use f strings to concatenate the 2 strings.
In our case, we have
invoice_path_template = "Invoices/{invoice_month}/Service Invoices/"
had it been missing the last "/"
invoice_path_template = "Invoices/{invoice_month}/Service Invoices"
on a windows system it would join with "\" and generate an incorrect S3 key.
>>> os.path.join("Invoices/{invoice_month}/Service Invoices", "local_file.csv").format(invoice_month="2025-11")
'Invoices/2025-11/Service Invoices\\local_file.csv'
Obviously, we don't support windows so we won't run into this failure but this is just an example. There's no advantage of using os.path.join only potential drawbacks.
Contributor
Author
There was a problem hiding this comment.
I switched to using basic string concatenation
Since invoices are now uploaded daily, simply downloading everything in the `Service Invoices` folder is not efficient. A list of invoice names have been added to track only the monthly invoices. This list needs to be updated if new services are added.
QuanMPhm
force-pushed
the
fix/s3_dates
branch
from
983d017 to
fcaf050
Compare
naved001
approved these changes
Dec 19, 2025
knikolla
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since invoices are now uploaded daily, simply downloading everything in the
Service Invoicesfolder is not efficient. A list of invoice names have been added to track only the monthly invoices. This list needs to be updated if new services are added.