Changed nerc-rates requirements to PyPi package #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmysway
force-pushed
the
fix/245-pypi-nerc-rates
branch
from
abd7824 to
abb6fbd
Compare
QuanMPhm
requested changes
Dec 16, 2025
Contributor
QuanMPhm
left a comment
QuanMPhm
left a comment
There was a problem hiding this comment.
This PR is combining two unrelated changes (implementing the fetch function, and updating the nerc-rates pin). Could you amend this PR so that it should only contain the commit to update the nerc-rates pin?
jimmysway
force-pushed
the
fix/245-pypi-nerc-rates
branch
from
abb6fbd to
aa07ec9
Compare
Contributor
Author
Sorry my apologies I completely missed this I just fixed this just now @QuanMPhm |
QuanMPhm
approved these changes
Jan 13, 2026
Contributor
Author
|
Closes #245 |
knikolla
reviewed
Jan 14, 2026
requirements.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| git+https://github.com/CCI-MOC/nerc-rates@33701ed#egg=nerc_rates | |||
| nerc-rates>=1.0.1 | |||
Contributor
There was a problem hiding this comment.
This needs to also be <2.
jimmysway
force-pushed
the
fix/245-pypi-nerc-rates
branch
from
aa07ec9 to
df321b2
Compare
knikolla
approved these changes
Jan 15, 2026
QuanMPhm
approved these changes
Jan 16, 2026
knikolla
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.