Implemented the Bare Metal invoice and processor classes #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanMPhm
commented
Feb 26, 2025
QuanMPhm
commented
Feb 26, 2025
QuanMPhm
force-pushed
the
152/bm_invoice
branch
from
811f9bb to
e1846ac
Compare
QuanMPhm
force-pushed
the
152/bm_invoice
branch
from
e1846ac to
aeb25fa
Compare
Contributor
Author
|
I have updated this PR, and consider it ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152. This PR consists of 3 commits to 1. implement the processor, 2. the invoice, and 3. a minor readability comment.
I am submitting this as a draft for now because I do not know how we want to identify BM projects. Refer to this comment for more context.
I also have a few small questions down below.