Method overloading support in script api #5242
Open
+85
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1zun4
reviewed
Jan 9, 2025
Comment on lines
107
to
108
| for (final var overload : overloads) | ||
| methodsToRemap.add(getReflectionMethodFromSingleMethod(overload)); |
but actually this is just logging in a catch block, for (var entry : entries) {
String key = entry.getKey();
Object value = entry.getValue();
String remapped;
try {
Member member = retriever.getMember(value);
remapped = remapDescriptor(member);
} catch (ReflectiveOperationException e) {
ClientUtilsKt.getLogger().error("Failed to remap field: {}", key, e);
continue;
}
if (remapped != null) {
map.remove(key);
map.put(remapped, value);
}
}Produced by enabling the following script (copied and combined from documentation), note that the key settings are still not yet correct. But the output in chat appears to be working as intended though. const script = registerScript({
name: "MyScript",
version: "1.0.0",
authors: ["My Name"]
});
script.registerModule({
name: "MyModule",
category: "Misc",
description: "An example module created with LiquidBounce's script API.",
settings: {
fastSwing: Setting.boolean({
name: "FastSwing",
default: true
}),
range: Setting.float({
name: "Range",
default: 3.0,
range: [0.5, 8.0],
suffix: "blocks"
}),
randomness: Setting.floatRange({
name: "Randomness",
default: [2.3, 7.8],
range: [0.0, 10.0],
suffix: "jitter"
}),
expand: Setting.int({
name: "Expand",
default: 4,
range: [0, 10],
suffix: "blocks"
}),
cps: Setting.intRange({
name: "CPS",
default: [4, 10],
range: [0, 20],
suffix: "cps"
}),
key: Setting.key({
name: "Key",
default: "key.keyboard.d"
}),
message: Setting.text({
name: "Message",
default: "This is a default message."
}),
messages: Setting.textArray({
name: "Messages",
default: ["This is a message", "This is another message"]
}),
animal: Setting.choose({
name: "Animal",
default: "Capybara",
choices: ["Axolotl", "Capybara", "Snek"]
})
}
}, (mod) => {
mod.on("enable", () => {
Client.displayChatMessage(`FastSwing: ${mod.settings.fastSwing.value}`);
Client.displayChatMessage(`Range: ${mod.settings.range.value}`);
Client.displayChatMessage(`Randomness: ${mod.settings.randomness.value}`);
Client.displayChatMessage(`Expand: ${mod.settings.expand.value}`);
Client.displayChatMessage(`CPS: ${mod.settings.cps.value}`);
Client.displayChatMessage(`Key: ${mod.settings.key.value}`);
Client.displayChatMessage(`Message: ${mod.settings.message.value}`);
Client.displayChatMessage(`Messages: ${mod.settings.messages.value}`);
Client.displayChatMessage(`Animal: ${mod.settings.animal.value}`);
mod.settings.fastSwing.value = false;
mod.settings.range.value = 2.3;
mod.settings.randomness.value = [2, 4.34];
mod.settings.expand.value = 2;
mod.settings.cps.value = [5, 12];
mod.settings.key.value = "key.keyboard.a";
mod.settings.message.value = "Axolotls are cool";
mod.settings.messages.value = ["New message 1", "New message 2"];
mod.settings.animal.value = "Axolotl";
});
});
script.registerCommand({
name: "addition",
aliases: ["add"],
parameters: [{
name: "a",
required: true,
validate: ParameterValidator.integer
},
{
name: "b",
required: true,
validate: ParameterValidator.integer
}
],
onExecute(arg1, arg2) {
Client.displayChatMessage(`Result of ${arg1} + ${arg2} is ${arg1 + arg2}`);
}
});
script.registerCommand({
name: "description",
parameters: [{
name: "module",
required: true,
validate: ParameterValidator.module,
}],
onExecute(mod) {
Client.displayChatMessage(`Description of module ${mod.name} is '${mod.description}'`);
}
});
|
|
This (intended behavior or not) is not introduced in this pr, and can be reproduced on previous build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes this issue, now corresponding method overloads can be automatically selected by arguments as shown below (Without using
ReflectionUtil).method-overload-support.mp4