Reflect auth0 roles in VIAL #660

ugotsoul · 2021-06-10T22:31:46Z

I tested this locally, by adding / removing "WB Trainee" and other auth0 roles to my user.

Expected behavior:

User's who are staff are getting flagged correctly
All auth0 roles will be reflected as a group that the user model belongs to
Auth0 roles that are reflected are environment specific: STAGING or local/prod
Auth0 roles are also reflected on the associated Reporter model of a User, if it exists
Group membership is updated in maybe a brutish way, since the auth0 only knows all the current roles. Hoping to solve this in New auth0 role VIAL WB Limited is not displaying in the Reporters page #633

How to test:

Logout of VaccinateCA locally
Add/Remove a role in auth0 to your local user: https://manage.auth0.com/dashboard/us/vaccinateca/users
Login to VaccinateCA locally
In VIAL view your user record groups and verify the role you added is in your "Chosen Groups"

- filter groups by environment - update env specific groups on user model - add readability to auth0 roles on reporter model

ugotsoul · 2021-06-10T22:32:50Z

vaccinate/auth0login/pipeline.py

-AUTH0_ROLES_TO_REFLECT = {
-    "Vaccinate CA Staff",
-    "VIAL super-user",
+AUTH0_ROLES_STAFF = {


Did I add all the staff roles? 🤔

codecov · 2021-06-11T02:50:11Z

The author of this PR, ugotsoul, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

ugotsoul · 2021-06-11T22:31:38Z

Oh yeah, one thing I'll need to do is update all the reports and locations that were made by wb trainee's to be pending review (after coordinating with the wb'ing team to make sure they didn't approve these or not!)

simonw · 2021-06-14T18:10:04Z

vaccinate/auth0login/pipeline.py

                group.user_set.add(user)
            else:
                group.user_set.remove(user)
+
+        # Note: Not all users are reporters
+        reporter_qs = Reporter.objects.filter(user=user)


You can use reporter = Reporter.objects.filter(user=user).first() here and it will either return a reporter or return None - which means you can then do if reporter: later on.

TY! I totally forgot about this.

simonw · 2021-06-14T18:10:28Z

Looks good to me - let's get this on staging and test it there.

ugotsoul · 2021-06-14T19:15:29Z

Testing on staging with my regular account ([email protected]) and got a bit worried I couldn't see admin pages, but I realized this was because there were no permissions assigned to these staging groups (whew!). https://vial-staging.calltheshots.us/dashboard/groups-and-permissions/

ugotsoul · 2021-06-14T19:18:09Z

@simonw would you be able to add permissions for these groups:

Vaccinate CA Staff STAGING
VIAL data corrections STAGING
VIAL service account STAGING
VIAL super-user STAGING

since I'm locked out of viewing/editing group permissions on staging? Hopefully you are still logged into staging 🙏🏾

ugotsoul · 2021-06-14T23:04:48Z

I got super user status and I was able to view groups again! I'm adding permissions to those groups above and also added a WB Trainee STAGING role for testing.

ugotsoul · 2021-06-14T23:09:27Z

I logged out/in after assigning WB Trainee STAGING and have this group displayed in my chosen groups and it is listed in the Groups page. 🙌🏾

ugotsoul added 3 commits June 8, 2021 14:16

Add/Sync auth0 roles and update staff role dict

437a0df

update roles on reporter model

dfae46f

Changes:

5c7c297

- filter groups by environment - update env specific groups on user model - add readability to auth0 roles on reporter model

ugotsoul commented Jun 10, 2021

View reviewed changes

Merge remote-tracking branch 'origin' into reflect_auth0_roles

363f65a

ugotsoul marked this pull request as draft June 10, 2021 22:38

ugotsoul added 3 commits June 10, 2021 17:46

fix: add/remove current groups to user

a44f87f

only add local roles to reporter model

04f6858

fix: don't index reporter queryset if its empty

81e827c

ugotsoul marked this pull request as ready for review June 11, 2021 02:50

ugotsoul requested a review from simonw June 11, 2021 02:50

Get staff roles in different envs using a function

df71ff6

simonw reviewed Jun 14, 2021

View reviewed changes

simonw merged commit 691ed62 into main Jun 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reflect auth0 roles in VIAL #660

Reflect auth0 roles in VIAL #660

ugotsoul commented Jun 10, 2021 •

edited

Loading

ugotsoul Jun 10, 2021 •

edited

Loading

codecov bot commented Jun 11, 2021

ugotsoul commented Jun 11, 2021

simonw Jun 14, 2021

ugotsoul Jun 14, 2021

simonw commented Jun 14, 2021

ugotsoul commented Jun 14, 2021 •

edited

Loading

ugotsoul commented Jun 14, 2021 •

edited

Loading

ugotsoul commented Jun 14, 2021

ugotsoul commented Jun 14, 2021

Reflect auth0 roles in VIAL #660

Reflect auth0 roles in VIAL #660

Conversation

ugotsoul commented Jun 10, 2021 • edited Loading

ugotsoul Jun 10, 2021 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jun 11, 2021

ugotsoul commented Jun 11, 2021

simonw Jun 14, 2021

Choose a reason for hiding this comment

ugotsoul Jun 14, 2021

Choose a reason for hiding this comment

simonw commented Jun 14, 2021

ugotsoul commented Jun 14, 2021 • edited Loading

ugotsoul commented Jun 14, 2021 • edited Loading

ugotsoul commented Jun 14, 2021

ugotsoul commented Jun 14, 2021

ugotsoul commented Jun 10, 2021 •

edited

Loading

ugotsoul Jun 10, 2021 •

edited

Loading

ugotsoul commented Jun 14, 2021 •

edited

Loading

ugotsoul commented Jun 14, 2021 •

edited

Loading