Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] #9 World 이벤트 관리 Observer 패턴 관련 Test Code 수정 #15

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[fix] #9 World 이벤트 관리 Observer 패턴 관련 Test Code 수정 #15

merged 1 commit into from
Dec 2, 2024

Conversation

yymin1022
Copy link
Member

@yymin1022 yymin1022 commented Dec 2, 2024 •
edited by win-luck
Loading

#️⃣ 연관 이슈

📝 작업 내용

#13 에서 작업한 World 이벤트 관리 Observer 패턴 관련된 Test가 동작하지 않던 문제를 해결하였습니다.
기존에 구성했던 TestGameEvent를 Test가 아닌 MockGameEvent로 변경하고, 별도의 리소스 디렉토리로 이동하였습니다.

💬 리뷰 요구사항

make test 커맨드가 정상 동작하는지에 대해 확인해주시면 됩니다. 별도로 패턴 관련 코드가 수정된 것은 없습니다.

@yymin1022 yymin1022 added the fix 버그 및 에러 수정 label Dec 2, 2024
@yymin1022 yymin1022 self-assigned this Dec 2, 2024
@yymin1022 yymin1022 linked an issue Dec 2, 2024 that may be closed by this pull request
[fix] #9 World 이벤트 관리 Observer 패턴 관련 Test Code 수정 #14
Closed
win-luck
win-luck approved these changes Dec 2, 2024
View reviewed changes
Copy link

@win-luck win-luck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 고생하셨습니다~!

ysndy
ysndy approved these changes Dec 2, 2024
View reviewed changes
Copy link

@ysndy ysndy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!! 고생하셨습니다~!

@yymin1022 yymin1022 merged commit 111cc79 into develop Dec 2, 2024
@hayeongKo
Copy link

확인했습니다 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@win-luck win-luck win-luck approved these changes

@ysndy ysndy ysndy approved these changes

@hayeongKo hayeongKo Awaiting requested review from hayeongKo

@devJS00 devJS00 Awaiting requested review from devJS00

Assignees

@yymin1022 yymin1022

Labels
fix 버그 및 에러 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] #9 World 이벤트 관리 Observer 패턴 관련 Test Code 수정
4 participants
@yymin1022 @hayeongKo @ysndy @win-luck