Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve scss build #307

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Feature/improve scss build #307

merged 3 commits into from
Dec 31, 2024

Conversation

poespas
Copy link
Collaborator

@poespas poespas commented Dec 31, 2024

  • Currently 3 css files (breakpoints/colors/general) were built without being loaded into the frontend, these are now ignored on buildtime
  • Compress/Minify stylesheet loaded on front-end
  • Build styling on buildtime in deployment
  • Use newest scss notiations ( @use )
  • Don't show scrollbars when not needed (non-iOS devices issue)

@@ -857,7 +857,7 @@ code.docutils.literal.notranslate {
margin: 0 20px 0 60px;
width: 100%;
max-width: calc(100% - 90px);
overflow: scroll;
overflow: auto;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this one accidental but was going to be apart of another code change another time, removes this scrollbar that is visible on smaller viewsizes on non-apple devices:

image

Copy link

Acceptance server is available at https://docs-ephjyi5eq.hypernode.io.
Changed pages:

@tdgroot tdgroot merged commit 56e7fe9 into master Dec 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants