Change the return type of volume_serial_number to u32.#7
Open
sunfishcode wants to merge 1 commit intoBurntSushi:masterfrom
Open
Change the return type of volume_serial_number to u32.#7sunfishcode wants to merge 1 commit intoBurntSushi:masterfrom
volume_serial_number to u32.#7sunfishcode wants to merge 1 commit intoBurntSushi:masterfrom
Conversation
Change the return types of `volume_serial_number()` and `number_of_links()` from `u64` to `u32`. This makes it easier to migrate code from manually using the underlying Windows APIs with `dwVolumeSerialNumber` and `nNumberOfLinks`, which are `u32`, to using `winapi_util::file::Information` instead. This also aligns with Rust nightly's [`windows_by_handle`] feature, where the [corresponding types are `u32`]. [`windows_by_handle`]: rust-lang/rust#63010 [corresponding types are `u32`]: https://doc.rust-lang.org/stable/std/os/windows/fs/trait.MetadataExt.html#tymethod.volume_serial_number
sunfishcode
added a commit
to bytecodealliance/cap-std
that referenced
this pull request
Feb 18, 2021
Use `winapi_util::file::information` in place of `winx::file::get_fileinfo`, which is simpler, except for needing to convert the types, which we need to do because we're ultimately using these values in the [windows `MetadataExt` trait] which uses `u32`. I submitted BurntSushi/winapi-util#7 to propose changing the types upstream. [windows `MetadataExt` trait]: https://doc.rust-lang.org/stable/std/os/windows/fs/trait.MetadataExt.html
sunfishcode
added a commit
to bytecodealliance/cap-std
that referenced
this pull request
Feb 18, 2021
Use `winapi_util::file::information` in place of `winx::file::get_fileinfo`, which is simpler, except for needing to convert the types, which we need to do because we're ultimately using these values in the [windows `MetadataExt` trait] which uses `u32`. I submitted BurntSushi/winapi-util#7 to propose changing the types upstream. [windows `MetadataExt` trait]: https://doc.rust-lang.org/stable/std/os/windows/fs/trait.MetadataExt.html
sunfishcode
added a commit
to bytecodealliance/cap-std
that referenced
this pull request
Feb 22, 2021
Use `winapi_util::file::information` in place of `winx::file::get_fileinfo`, which is simpler, except for needing to convert the types, which we need to do because we're ultimately using these values in the [windows `MetadataExt` trait] which uses `u32`. I submitted BurntSushi/winapi-util#7 to propose changing the types upstream. [windows `MetadataExt` trait]: https://doc.rust-lang.org/stable/std/os/windows/fs/trait.MetadataExt.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the return types of
volume_serial_number()andnumber_of_links()fromu64tou32. This makes it easier to migratecode from manually using the underlying Windows APIs with
dwVolumeSerialNumberand
nNumberOfLinks, which areu32, to usingwinapi_util::file::Informationinstead.This also aligns with Rust nightly's
windows_by_handlefeature,where the corresponding types are
u32.