Skip to content

build: emit warning if git is missing during build #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: emit warning if git is missing during build #3057

wants to merge 1 commit into from

Conversation

kevichi7
Copy link

Adds a cargo:warning if git is not available during build.
This makes it easier to understand why RIPGREP_BUILD_GIT_HASH might be missing, without breaking the build.

BurntSushi
BurntSushi approved these changes Aug 19, 2025
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Note that using eprintln! here is incorrect, and causes this warning to get swallowed. You need to print the warning to stdout.

I also made a few other touch-ups in my rollup branch.

@BurntSushi BurntSushi added the rollup A PR that has been merged with many others in a rollup. label Aug 19, 2025
BurntSushi pushed a commit that referenced this pull request Aug 19, 2025
@kevichi7 @BurntSushi
build: emit warning if git is missing during build
8ab9b6a 
Closes #3057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees
No one assigned
Labels
rollup A PR that has been merged with many others in a rollup.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevichi7 @BurntSushi