rollup a number of recent PRs #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deserializing `jiff` types from YAML is not currently possible. Neither `serde_yaml` nor its maintained fork `serde_yml` support deserializing from bytes. These tests serve in both - proving the current incompatibility - verifying the fix in the following commit, which migrates `Deserialize` implementations to `deserializer.deserialize_str`. Ref #138, Ref #148
Deserializing `jiff` types from YAML was previously not possible. Namely, neither `serde_yaml` nor its maintained fork `serde_yml` support deserializing from bytes. This changset migrates `Deserialize` implementations to `deserializer.deserialize_str`, thus providing serde YAML compatibility. There is some more discussion about this inconsistency at a higher level in #138. Fixes #138, Fixes #148, Closes #149
Closes #150
The colored docs.rs badge is quick to spot, which increases ergonomics for library users. Closes #153
This mostly implements `Hash` for all types that also implement `PartialEq` and `Eq`, but notably omits one for `Span`. The reason being that I'm currently planning on removing the `PartialEq` and `Eq` implementations of `Span`, so I'd prefer not to add more API surface area that relies on it. Closes #143
The documentation for the deprecated `as_duration` function in `Timestamp` referenced a non-existent function `as_signed_duration`. It should point to `as_jiff_duration` instead. Closes #142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a rollup of most of the outstanding PRs with some light
editing of commit messages and the addition of CHANGELOG entries.
Closes #138
Closes #148
Closes #149
Closes #161
Closes #150
Closes #153
Closes #143
Closes #142