Resolving clippy warning #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
requested changes
Nov 14, 2023
There was a problem hiding this comment.
I don't really agree with most of these changes. I don't feel terribly strong about most of them, but generally prefer to not accept most of these. This is why I don't have Clippy setup to run. (I realize I could pick and choose which lints I want to enable, but this is a lot of work to do across the number of repos I maintain and just ultimately isn't worth it for me.)
I marked the changes that I agree with.
|
Is this okay with you? @BurntSushi Regarding your opinion on Clippy, I will take note of that. Currently, I am studying string searching related to the unstable search function in the Rust compiler and came across your great works, specifically Aho-Corasik's :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cut the Clippy warnings in half, dropping from 57 to 28. The remaining warnings likely require changes to variable names.
@BurntSushi