Fix compositing performance (3x improvement) #208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test
Comment out
tickRelationshipOutlines();
inneo4jd3.js
like this:This removes other bottlenecks. Compare the performance of dragging around icons before vs after this change.
Before (75ms total task time~, around 50ms is compositing):
![image](https://user-images.githubusercontent.com/7528322/165595115-f3bb3598-278d-42b4-ad0b-09ec5c079740.png)
After (25ms total task time~, around 1ms is composting):
![image](https://user-images.githubusercontent.com/7528322/165595521-bb3fbdb2-4406-48c0-93d3-81164a8a370e.png)
Reference: https://stackoverflow.com/a/40533907/3991315