Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compositing performance (3x improvement) #208

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

BurkusCat
Copy link
Owner

@BurkusCat BurkusCat commented Apr 27, 2022

How to test

Comment out tickRelationshipOutlines(); in neo4jd3.js like this:

            tickRelationshipsTexts();
            //tickRelationshipsOutlines();
            tickRelationshipsOverlays();

This removes other bottlenecks. Compare the performance of dragging around icons before vs after this change.

Before (75ms total task time~, around 50ms is compositing):
image

After (25ms total task time~, around 1ms is composting):
image

Reference: https://stackoverflow.com/a/40533907/3991315

@BurkusCat BurkusCat requested a review from Trufflegator April 27, 2022 18:32
@BurkusCat BurkusCat changed the title Fix compositing performance Fix compositing performance (3x improvement) Apr 27, 2022
@BurkusCat
Copy link
Owner Author

Improves #8

Copy link
Collaborator

@Trufflegator Trufflegator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will keep an eye out for if anything breaks.

@Trufflegator Trufflegator merged commit 84f5bff into master Apr 27, 2022
@BurkusCat BurkusCat deleted the improve-graph-performance branch April 27, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants