Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update by in join block (in case of empty set intersection) #274

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nbenn
Copy link
Collaborator

@nbenn nbenn commented Feb 7, 2024

Fixes #273, currently at the expense of breaking the filter block. Working on a solution to have both.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (58043a4) 74.82% compared to head (abdca1f) 77.27%.

Files Patch % Lines
R/block.R 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   74.82%   77.27%   +2.44%     
==========================================
  Files          17       17              
  Lines        1903     1905       +2     
==========================================
+ Hits         1424     1472      +48     
+ Misses        479      433      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbenn
Copy link
Collaborator Author

nbenn commented Feb 7, 2024

@DivadNojnarg I reverted a change you introduced in 1d395df, and by the commit msg you were trying to fix an issue with the filter block. I made a small change in the filter block implementation to not require this change. I GUI-checked the blocks currently in the registry and did not see any further issues. When you have updated the registry we can quickly look at whether this causes problems for the remaining blocks.

@nbenn nbenn changed the title Update by in join block Update by in join block (in case of empty set intersection) Feb 7, 2024
@DivadNojnarg
Copy link
Collaborator

There's also something about the filter expression: it is including call(+, ..., ...). I wrote this long time ago so there might be an easy way to make it nicer, that is not like this:

get("ae", envir = as.environment("package:blockr.data")) %>%
        dplyr::filter(eval(call("==", DOMAIN, "AE")))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset switch in join block does not update by
2 participants