Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP redo names/IDs #127

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP redo names/IDs #127

wants to merge 1 commit into from

Conversation

nbenn
Copy link
Collaborator

@nbenn nbenn commented Dec 13, 2023

No description provided.

@nbenn nbenn requested a review from DivadNojnarg as a code owner December 13, 2023 12:22
@nbenn nbenn marked this pull request as draft December 13, 2023 12:22
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17ca711) 73.48% compared to head (05d1ef8) 73.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   73.48%   73.51%   +0.03%     
==========================================
  Files          16       16              
  Lines        1712     1714       +2     
==========================================
+ Hits         1258     1260       +2     
  Misses        454      454              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbenn nbenn mentioned this pull request Dec 14, 2023
@DivadNojnarg
Copy link
Collaborator

@nbenn: I would also need the block ID refactoring to handle the remove block feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants