feat: add clickElemAt & hoverElemAt
#542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
reviewed
Nov 13, 2024
dlockhart
reviewed
Nov 14, 2024
dlockhart
reviewed
Nov 14, 2024
dlockhart
approved these changes
Nov 14, 2024
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #281
Alternative setup would be
clickElemAt(elem, xOffset = 0, yOffset = 0)which likely brings it in line closer to how users expect things to work when coming fromclickAtandhoverAtbut I have it penciled in asclickElemAt(elem, offset = { x: 0, y: 0 })right now just because it felt cleaner to me but it's a quick change.Honestly on second thought, I'll likely just swap to using it as xOffset, yOffset since it makes more sense to follow pattern.
Just adding documentation and then it's ready for full review