fix: Tables: style td in table header as th, use td instead of th for select all headers #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… select all headers
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
approved these changes
Nov 25, 2024
|
🎉 This PR is included in version 3.72.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
Related PR: https://github.com/Brightspace/lms/pull/59520
Context:
This came up in the accessibility audit in the context of the LMS Rubrics table. When a select all textbox is in a th, it causes all the checkboxes within the column to also read whatever the "select all" text is on the checkbox.
Solution Notes:
The auditor recommended that these select all checkboxes should be in a
thrather than atd. Currently we only stylethcells within a table header to have background color etc so this updates those and also fixes our example table.