Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAYL-89 Improve Breadcrumb a11y docn #5128

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

geurts
Copy link
Contributor

@geurts geurts commented Nov 1, 2024

Adds a11y tag to relevant properties and introduces the new page level Accessibility section.

Moves the Responsive section lower in the document (it seemed strange to lead with that section).

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5128/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

Removes "required" from 'text' property (as discussed) and updates readme-specific Property tables to align with the descriptions used in code (so that it aligns with the Daylight site).
Copy link
Contributor

@ChrisLabattD2L ChrisLabattD2L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Also cool to learn about why we don't use the visited link style for breadcrumbs. It makes sense in hindsight, but was always something I was curious about!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants