Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Nullable in Core and Service Activator #3294

Merged
merged 10 commits into from
Sep 23, 2024
Merged

Enable Nullable in Core and Service Activator #3294

merged 10 commits into from
Sep 23, 2024

Conversation

preardon
Copy link
Member

@preardon preardon commented Sep 4, 2024

No description provided.

@preardon
Copy link
Member Author

preardon commented Sep 4, 2024

@iancooper As discussed I think the better example here is the second commit (Service Activator) but let me know what you think.

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Sep 17, 2024
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.01 (9.59 -> 9.59)

  • Declining Code Health: 2 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 2 files(s) 🔥

View detailed results in CodeScene

src/Paramore.Brighter/Monitoring/Events/MonitorEvent.cs Show resolved Hide resolved
src/Paramore.Brighter.ServiceActivator/ControlBus/ControlBusReceiverBuilder.cs Show resolved Hide resolved
src/Paramore.Brighter.ServiceActivator/MessagePumpAsync.cs Show resolved Hide resolved
src/Paramore.Brighter.ServiceActivator/MessagePumpBlocking.cs Show resolved Hide resolved
codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Sep 17, 2024
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (9.43 -> 9.42)

  • Declining Code Health: 5 findings(s) 🚩
  • Improving Code Health: 3 findings(s) ✅
  • Affected Hotspots: 3 files(s) 🔥

View detailed results in CodeScene

src/Paramore.Brighter/InternalBus.cs Show resolved Hide resolved
src/Paramore.Brighter/ExternalBusService.cs Show resolved Hide resolved
src/Paramore.Brighter/ExternalBusService.cs Show resolved Hide resolved
codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Sep 18, 2024
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (9.46 -> 9.45)

  • Declining Code Health: 5 findings(s) 🚩
  • Improving Code Health: 3 findings(s) ✅
  • Affected Hotspots: 3 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Sep 21, 2024
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.02 (9.46 -> 9.44)

  • Declining Code Health: 5 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 3 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Sep 23, 2024
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (9.47 -> 9.46)

  • Declining Code Health: 5 findings(s) 🚩
  • Improving Code Health: 2 findings(s) ✅
  • Affected Hotspots: 3 files(s) 🔥

View detailed results in CodeScene

src/Paramore.Brighter/CommandProcessorBuilder.cs Show resolved Hide resolved
src/Paramore.Brighter.MessagingGateway.AzureServiceBus/AzureServiceBusConsumer.cs Show resolved Hide resolved
src/Paramore.Brighter.MessagingGateway.MsSql/SqlQueues/MsSqlMessageQueue.cs Show resolved Hide resolved
@preardon preardon marked this pull request as ready for review September 23, 2024 09:22
codescene-delta-analysis[bot]
codescene-delta-analysis bot reviewed Sep 23, 2024
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (9.47 -> 9.46)

  • Declining Code Health: 5 findings(s) 🚩
  • Improving Code Health: 2 findings(s) ✅
  • Affected Hotspots: 3 files(s) 🔥

View detailed results in CodeScene

@preardon preardon merged commit 8214a9c into master Sep 23, 2024
10 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes

@iancooper iancooper iancooper approved these changes

@holytshirt holytshirt Awaiting requested review from holytshirt holytshirt is a code owner

@DevJonny DevJonny Awaiting requested review from DevJonny DevJonny is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preardon @iancooper