Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stringtable: allow bin with just warnings #854

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

BrettMayson
Copy link
Owner

  • Improves testings
  • Allows bin if the codes returned by lints are just warnings

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.5%. Comparing base (9f04af8) to head (b7d8d73).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/src/modules/stringtables/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/stringtable/src/analyze/lints/l01_sorted.rs 78.0% <ø> (ø)
libs/stringtable/src/analyze/mod.rs 89.2% <ø> (+42.8%) ⬆️
libs/stringtable/src/package.rs 88.6% <100.0%> (+78.2%) ⬆️
libs/stringtable/src/rapify.rs 82.5% <ø> (+4.0%) ⬆️
bin/src/modules/stringtables/mod.rs 42.8% <0.0%> (ø)

... and 2 files with indirect coverage changes

@BrettMayson BrettMayson merged commit f2c2356 into main Dec 20, 2024
31 of 37 checks passed
@BrettMayson BrettMayson deleted the stringtable_coverage branch December 20, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant