Star battle borders added #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Empty Adjacent Test (one of those one line deletion bug fixes) and got rid of print statements and comments blocking useful lines of code
Starter code for borders
Added primitive code to outline where borders would be placed
commented out rough draft on how element view draws borders. Don't need an image for them likely, just use basic drawRect function, and make sure to distinguish if it's vertical or horizontal if necessary
Made dedicated border classes to help define them for drawing
Changed how borders were counted and drawn to be more in line with skyscrapers
Borders added, slipped in-between cells equally, colored red so as to not be confused with the black empty squares
Attempting to solve merge issue
Undoing changes to fix merge conflict
More undoing
jadeandtea
reviewed
Oct 21, 2024
The commented out else statement is old code from when I considered making the borders a cell type, which I ultimately didn't do, so I should be able to get rid of it, maybe at a later date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a warning about the test, I'll fix that later, but for now I excluded it because there were problems with merging if I fixed it. Will deal with later.