-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated puzzles to add persistent tags, hashed the exported solved state of the board, and updated batch grader to new format #865
Open
Lukas-Petervary
wants to merge
12
commits into
Bram-Hub:dev
Choose a base branch
from
Lukas-Petervary:master
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remerge updated binary puzzle, proof editor, puzzle editor, home panel, bug fixes
Will wait until Bram reviews the autograder. |
jadeandtea
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Bram looked over the batch grader functionality and approved. He requested a puzzle type drop-down menu, so I'll wait for that before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated puzzles to add persistent tags, hashed the exported solved state of the board, and updated batch grader to new format.
Type of change
How Has This Been Tested?
Step through normal workflow: create new puzzle, save and export, then open new puzzle, make changes, save and exit. Check file for correct persistent tag, then reopen and solve, export one more time and ensure correct data and format. Finally, run autograder over solved and unsolved puzzles to ensure un-hashing correctness.
Testing only works with updated puzzles with new export features. Old puzzles will have to be updated to new format, but will not break the batch grader if graded (they will simply print "Error" in the results).
Checklist: