Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated puzzles to add persistent tags, hashed the exported solved state of the board, and updated batch grader to new format #865

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

Lukas-Petervary
Copy link

@Lukas-Petervary Lukas-Petervary commented Oct 15, 2024

Description

Updated puzzles to add persistent tags, hashed the exported solved state of the board, and updated batch grader to new format.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Step through normal workflow: create new puzzle, save and export, then open new puzzle, make changes, save and exit. Check file for correct persistent tag, then reopen and solve, export one more time and ensure correct data and format. Finally, run autograder over solved and unsolved puzzles to ensure un-hashing correctness.
Testing only works with updated puzzles with new export features. Old puzzles will have to be updated to new format, but will not break the batch grader if graded (they will simply print "Error" in the results).

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jadeandtea jadeandtea self-requested a review November 8, 2024 22:29
@jadeandtea
Copy link
Collaborator

Will wait until Bram reviews the autograder.

Copy link
Collaborator

@jadeandtea jadeandtea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Bram looked over the batch grader functionality and approved. He requested a puzzle type drop-down menu, so I'll wait for that before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants