Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star battle Empty Adjacent Rule (wip) #845

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

offline171
Copy link
Collaborator

Description

Closes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Basic form of EmptyAdjacentDirectRule implemented, tests coming soon
Added some tests that revealed there is a problem with how the program retrieves the location of the tile in question.
An issue where the test file would fail before any of the tests started was fixed
Issue has been found where changes that are meant to be isolated within the rule's temporary board are instead permanent, considering if copy constructor is the problem
@summerhenson summerhenson merged commit 9abd9c0 into Bram-Hub:star-battle Jul 26, 2024
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants