Revert .json loading in tsconfig and use require #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to a26e891 in 17 seconds
More details
- Looked at
27lines of code in2files - Skipped
1files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_pCY6i8A4EnB4BJzL
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -16,7 +16,7 @@ import type { BamlVSCodePlugin } from '../types' | |||
| import { URI } from 'vscode-uri' | |||
| import StatusBarPanel from '../../panels/StatusBarPanel' | |||
|
|
|||
| import packageJson from '../../../package.json' | |||
| const packageJson = require('../../../../package.json') // eslint-disable-line | |||
There was a problem hiding this comment.
Using require for JSON files is not recommended in TypeScript. Consider using import packageJson from '../../../../package.json' assert { type: 'json' }; for better type safety and module resolution.
sxlijin
reviewed
Oct 21, 2024
| @@ -2,7 +2,7 @@ | |||
| "name": "baml-client", | |||
| "displayName": "Baml - Insider - Client", | |||
| "description": "This is the Insider Build of the Baml VS Code extension (only use it if you are also using the dev version of the CLI).", | |||
| "version": "0.62.0", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Reverts JSON loading in
index.tsto userequireand updates version inpackage.jsonto1.1.0.index.tsfrom ES6importto CommonJSrequireforpackage.json.package.jsonfrom0.62.0to1.1.0.This description was created by
for a26e891. It will automatically update as commits are pushed.