Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to make VSCode compile #1077

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Attempt to make VSCode compile #1077

merged 1 commit into from
Oct 21, 2024

Conversation

hellovai
Copy link
Contributor

@hellovai hellovai commented Oct 21, 2024

Important

Update version in package.json and fix import path in index.ts.

  • Version Update:
    • Update version in package.json from 0.1.1 to 0.62.0.
  • Import Path Fix:
    • Correct import path of packageJson in index.ts to ../../../package.json.

This description was created by Ellipsis for 7457f35. It will automatically update as commits are pushed.

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:51pm

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7457f35 in 9 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. typescript/vscode-ext/packages/vscode/src/plugins/language-server/index.ts:19
  • Draft comment:
    The import path for packageJson was corrected. Ensure that the new path is correct and that the package.json file is in the expected location.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import path for packageJson was corrected, which is necessary for the code to compile correctly. This change aligns with the intent of the PR to make VSCode compile.

Workflow ID: wflow_GhCMQaCpDLTXQTyX


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@hellovai hellovai added this pull request to the merge queue Oct 21, 2024
Merged via the queue into canary with commit fe088fd Oct 21, 2024
10 checks passed
@hellovai hellovai deleted the tsconfig-patch branch October 21, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant