-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support serializing/deserializing baml_py.Image, baml_py.Audio with pydantic #1062
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 9d6fe0c in 29 seconds
More details
- Looked at
496
lines of code in10
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_Z4acSdfijKOd3vqI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on ddb0300 in 12 seconds
More details
- Looked at
33
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. engine/language_client_python/src/errors.rs:65
- Draft comment:
Avoid unnecessaryclone()
calls onprompt
,message
, andraw_output
if they are already owned values. This can help reduce performance overhead. - Reason this comment was not posted:
Confidence changes required:50%
The use ofclone()
onprompt
,message
, andraw_output
in theraise_baml_validation_error
call is unnecessary if these are already owned values. This can lead to unnecessary performance overhead.
Workflow ID: wflow_RaaQjW68QV2Eldep
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
ddb0300
to
5f5f3c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 5f5f3c4 in 13 seconds
More details
- Looked at
17
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. engine/language_client_python/src/types/media_repr.rs:71
- Draft comment:
Consider moving the explanation about not placing this function inbaml_py.internal_monkeypatch
to documentation or a design document for better maintainability. - Reason this comment was not posted:
Confidence changes required:50%
The comment block from lines 71 to 75 explains why the function is not placed inbaml_py.internal_monkeypatch
. This is a good explanation, but it might be more appropriate to place this explanation in the documentation or a design document rather than in the code comments.
Workflow ID: wflow_HhsWj9APiypDz5bA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 58a44f8 in 22 seconds
More details
- Looked at
37
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. engine/language_client_python/src/types/function_results.rs:3
- Draft comment:
Remove unused importPyListMethods
. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_su0uEn4lCNocEIDW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add Pydantic support for
baml_py.Image
andbaml_py.Audio
serialization/deserialization with tests and documentation updates.baml_py.Image
andbaml_py.Audio
inmedia_repr.rs
,audio.rs
, andimage.rs
.baml_serialize
andbaml_deserialize
methods forBamlImagePy
andBamlAudioPy
.supported-types.mdx
with Pydantic compatibility details forImage
.test_pydantic.py
to validate Pydantic model creation and serialization forbaml_py.Image
.dead_code
andunused_imports
inCargo.toml
.This description was created by for 58a44f8. It will automatically update as commits are pushed.