Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added intlTelInput-jquery.min.js #55

Closed
wants to merge 1 commit into from
Closed

Added intlTelInput-jquery.min.js #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/PhoneInputAsset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class PhoneInputAsset extends AssetBundle
public $js = [
'build/js/utils.js',
'build/js/intlTelInput.min.js',
'build/js/intlTelInput-jquery.min.js',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@i-panov I believe since https://github.com/jackocnr/intl-tel-input made a "separate jQuery wrapped version" - we should replace build/js/intlTelInput.min.js with build/js/intlTelInput-jquery.min.js, right? I don't think we should be using both at once

Copy link
Author

@i-panov i-panov Nov 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borales Perhaps you are right. I did not understand what js files are needed or not needed by this library. I just saw that when intlTelInput-jquery.min.js was connected everything worked. But since if you disable intlTelInput.min.js, nothing breaks (I checked), you can remove it. A new problem is in another - in one of the latest updates bower/intl-tel-input the file intlTelInput-jquery.min.js was missing. And now if I try to connect it, I get 404. You do not know what happened there? I see that it is in the github repository, but it is not downloaded out by a composer...

];
/** @var array */
public $depends = ['yii\web\JqueryAsset'];
Expand Down