Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMakeLists.txt of JoltPhysics #462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update CMakeLists.txt of JoltPhysics #462

wants to merge 1 commit into from

Conversation

AyiStar
Copy link

@AyiStar AyiStar commented Oct 18, 2023

Add /Wv:18 option to prevent warnings from newer vc version when building JoltPhysics.

@AyiStar
Update CMakeLists.txt
0753ddc 
Add /Wv:18 to prevent warnings from newer vc version
@AyiStar
Copy link
Author

AyiStar commented Oct 18, 2023 •
edited
Loading

我注意到 #390 和 #452 都提到了这个问题，但是并没有得到修正。直接去掉 JoltPhysics 的 /WX 选项过于粗暴，考虑到可能是项目所使用的 JoltPhysics 版本较旧的问题，在不改变此部分代码的前提下，一个比较温和的方式是在编译 JoltPhysics 的时候，通过 /Wv[:version] 选项关闭新版本MSVC引入的warning。 @ShenMian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AyiStar