-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (#<|) and deprecate its alias (<|#) #9
Conversation
Note: For now, I use |
Thanks, interesting! Could you please mention the caveat about spaces around I'm a bit reluctant to accumulate pragmas and would rather wait for Ormolu / Formolu to fix the formatting issue. |
b24518b
to
ce47ad2
Compare
I added a mention about the caveat in the doc and in the code.
I discovered this caveat by mere curiosity: GHC had no issue with
Agreed. I reduced to only one comment at the beginning of the file. A fix is already in the work, see tweag/ormolu#1063. I do not think you should wait for a formatting tool to be fixed to merge this PR, as it introduces a deprecation in a young library: the sooner you release, the lesser users will need migration. |
Previously the documentation stated that `(#<|)` was not supported by the parser. It turns out it is a silly interaction with `-XUnboxedTuples`. Adding extra spacing between the parentheses and the function fixes the issue. This commit adds `(#<|)` and makes `(<|#)` its deprecated alias.
f3eb282
to
1999f3b
Compare
Rebased. I tested with success formatting with |
Waiting for fourmolu/fourmolu#369 to be released. |
1999f3b
to
b833a7f
Compare
I removed the commit with the special Fourmolu comments. |
Previously the documentation stated that
(#<|)
was not supported by the parser. It turns out it is a silly interaction with-XUnboxedTuples
. Adding extra spacing between the parentheses and the function fixes the issue.This commit adds
(#<|)
and makes(<|#)
its deprecated alias.