Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how-to compile example instructions #380

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Jun 30, 2024

Fixes #379

I could not compile examples/simple.c using the instructions in the file. This PR proposes an update on how-to compile examples/simple.c and examples/noinit.c. I'm not experienced in using GCC, so this change may be incorrect in some subtle way, but these new instructions work on my machine.

@kalvdans
Copy link
Contributor

kalvdans commented Jul 1, 2024

The instructions should still link an already built libblosc.a instead of recompiling the library. I'll see if I can come up with better commands during the coming days. [EDIT] See the linked issue, I replied there.

Copy link
Contributor

@kalvdans kalvdans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice impovement, thanks! (I have no merge rights)

@FrancescAlted FrancescAlted merged commit f6ce077 into Blosc:main Jul 20, 2024
18 checks passed
@FrancescAlted
Copy link
Member

Thanks @nhz2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help compiling example
3 participants