Fix display #101
Merged
Fix display #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simfony::Arguments and simfony::WitnessValues can be printed as
`mod param { ... }` and `mod witness { ... }`, respectively.
We almost never need this, but when we do, it is helpful to print the
module items `const NAME: TYPE = Value` in order of `NAME`.
Because simfony::Arguments and simfony::WitnessValues internally use
HashMap, their keys are not sorted. Manually sorting the keys is
computationally expensive, but we rarely need this code. Printing modules
is basically only required for the web IDE and it is not required for the
Simfony compiler itself. The Simfony compiler benefits from the armotized
complexity of the HashMap operations.
The implementation of fmt::Display for Value loops over each inner value in (verbose) pre-order. This makes it hard to display a larger value in a custom way while hiding its inner values. The updated implementation tries to parse a Simfony array as a non-empty byte array. If this succeeds, the bytes are displayed as hex and a flag is set to true. The flag hides the inner values of the array, which have already been printed. At the end, the flag is set to false again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes how modules and values are displayed.