Fix jets-bench build for macOS#335
Merged
apoelstra merged 1 commit intoBlockstreamResearch:masterfrom Jan 11, 2026
Merged
Conversation
Contributor
Author
|
I was talking with Kyrylo about the issue that he had, and remembered that I had seen something similar once. Decided that it was worth fixing it |
Contributor
Author
|
I don't like |
Collaborator
|
Yeah. It's amazing how badly incomplete Rust's stdlib is. Unfortunately I think it's better to have slightly better code than a whole extra dependency. |
delta1
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS there are compilation errors due to incorrect type aliasing —
CFrameItem::new_readexpects an array ofUWORD (u16), but getsusizeinstead. This probably worked elsewhere becauseusizewasu16depending on the platform. This PR fixes the type mismatch.