Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zkp: Musig2 module #29

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GeneFerneau
Copy link

Adds high-level Rust bindings for Musig2 multi-signature protocol

@GeneFerneau
Copy link
Author

Diff looks much larger than it actually is, since I pulled in @jonasnick's changes to secp256k1-zkp.

Main changes are in secp256k1-zkp-sys/src/zkp.rs and rust-secp256k1-zkp/src/zkp/musig.rs.

Will rebase, and update as changes are merged from #131

@GeneFerneau
Copy link
Author

Updated on #131/0c43aae

src/zkp/musig.rs Outdated Show resolved Hide resolved
@GeneFerneau
Copy link
Author

Rebased on latest master ab7f6d8

Updated to use schnorrsig::PublicKey.

Still need to rebase on @jonasnick's latest work, but may wait until the work is finished in their PR.

src/zkp/musig.rs Outdated Show resolved Hide resolved
@elsirion
Copy link

Still need to rebase on @jonasnick's latest work, but may wait until the work is finished in their PR.

Agreed, too much work otherwise. Thanks for writing the code in the first place, before the PR was even merged! Was super happy I didn't have to do it myself 😃

@sanket1729
Copy link
Member

Hi @GeneFerneau, musig2 spec and all PRs(but the tweaking support) have been merged upstream. Do you have any plans to resume this?

@sanket1729
Copy link
Member

sanket1729 commented Mar 21, 2022

Hi @GeneFerneau, I could not resist playing with this branch. I made a few fixups to make it work after #46. Your previous work was very clean, this only required a few changes: https://github.com/sanket1729/rust-secp256k1-zkp/tree/pr29

If you are busy with other commitments, I can pick this up. Otherwise, feel free to cherry-pick and squash above PR and lets get to review :)

@sanket1729 sanket1729 mentioned this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants