halfagg: Expand on limit of signatures #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #16 that just improves the text a bit.
A middle way between this and #16 will be to make the limit a parameter. That is, the algorithms enforce some limit, but we leave the actual value unspecified. The more I think about this, the more I like the idea. It frees us from picking a value, but we still tell implementors how to handle the limit. The only drawback of this approach is that we'll have to pick some value in our tests in order to instantiate the algorithm. I guess, that's fine, and we can really pick whatever we want, even much lower than 2^16-1?!
What do you think?