Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes node-rdkafka work correctly with worker_threads. There were several issues which needed resolving and some changes which were needed to prevent data being shared across threads and to ensure everything is cleaned up completely when the thread exits.
Changes included:
NODE_MODULE_CONTEXT_AWARE
to init moduleuv_default_loop()
, need to get the loop owned by the current thread.Dispatcher::Deactivate()
on destruct to stopuv_async_t
so thread can teardown loop safelyConnection
andTopic
types need cleanup hooks to ensure they are deleted when the thread is torn down.Conf
with correctly-sized type so destructor and sub-class fields aren't overwriting random memoryAsyncWorker
types uniqueAsyncResource
names for better debugging