Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tell the client the LevelChainId before it uses it to read a variable bit length message #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tell the client the LevelChainId before it uses it to read a variable bit length message #75

wants to merge 1 commit into from

Commits on Oct 24, 2020

  1. Tell the client the LevelChainId before it uses it to read a variable… 

    … bit length message

Fixes very serious dormant vanilla bug where any planet with a level chain that had a different max level to the level chain with an id of 0 would read the wrong number of bits from the message, and offset the rest of the message by a number of bits, breaking all later decoding (and before I started patching to get my way to here, also risk CTDing the client due to trying to create data with stupidly large sizes on the graphics code). This bug is part of vanilla, but could not be triggered without mods, as all level chains in vanilla had 5 levels, so the bug occured but didn't break the decoding due to the incorrect number and correct number coinciding to be the same
    @Skeletonxf
    Skeletonxf committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    3dcbf28 View commit details
    Browse the repository at this point in the history