Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/definitions/pickups.as: check if a pickup was picked before #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

scripts/definitions/pickups.as: check if a pickup was picked before #57

wants to merge 1 commit into from

Conversation

l29ah
Copy link
Contributor

@l29ah l29ah commented Oct 6, 2018

fixes #45

@Legendsmith
Copy link

Legendsmith commented Aug 10, 2020 •
edited
Loading

Hey! I reported this bug in 2017, Thanks for fixing it.

DaloLorn referenced this pull request in OpenSRProject/OpenStarRuler-Modpack Aug 31, 2020
@DaloLorn
Cloned files in preparation for porting pull requests BlindMindStudio…
dbeffe4 
…s/StarRuler2-Source#20 and BlindMindStudios/StarRuler2-Source#45.
DaloLorn
DaloLorn suggested changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@DaloLorn DaloLorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only just realized how horribly wrong this is... good thing I was rewriting it anyway. 😟

Your solution means that each pickup type can be collected once. The correct solution is to make each pickup object track whether it's been collected yet.

DaloLorn added a commit to OpenSRProject/OpenStarRuler-Modpack that referenced this pull request Aug 31, 2020
@DaloLorn
Cloned more files for BlindMindStudios/StarRuler2-Source#57.
8bb77bf
DaloLorn added a commit to OpenSRProject/OpenStarRuler-Modpack that referenced this pull request Aug 31, 2020
@DaloLorn
Ported a fixed variant of BlindMindStudios/StarRuler2-Source#57.
16e8fe5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaloLorn DaloLorn DaloLorn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unlimited remnant pickups exploit
3 participants
@l29ah @Legendsmith @DaloLorn