Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Tina to latest version #61

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

logan-anderson
Copy link
Contributor

Hello Team,

Logan here from from the Tina team. Was just looking over at the starter and it seems that you are on an older version of Tina.

Here is a PR that updates it to the latest version and fixes all of the breaking changes. Let me know if you have any questions.

@vercel
Copy link

vercel bot commented Dec 12, 2022

@logan-anderson is attempting to deploy a commit to the Blazity Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-saas-starter ❌ Failed (Inspect) Dec 14, 2022 at 11:55AM (UTC)

.tina/config.ts Outdated
publicFolder: 'public',
},
schema,
branch,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it still possible to use tina locally? I don't want to push user to use tina cloud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmstefanski What is the error you are seeing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything should work locally

Copy link
Contributor Author

@logan-anderson logan-anderson Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into this more, are you talking about building the App without needing Tina Cloud integration?

Right now we promote using Tina Cloud on the server side (even on CI). I am guessing that vercel error is something like this

Error: Client not configured properly. Missing branch, clientId, token. Please visit https://tina.io/docs/tina-cloud/connecting-site/ for more information

This is because to build your app you need to query tina cloud.

If you want to build the app without Tina Cloud the build command would have to look like this.

build: "tinacms dev -c 'next build' "

However this would not build admin interface for production.

I will make this the default build script (so the site will build without TinaCloud) and update the README to add docs of how to edit the script so the site can be used with TinaCloud and you can edit in production.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this error when deploying to vercel or trying to build in local

Error occurred prerendering page "/admin/[[...tina]]". Read more: https://nextjs.org/docs/messages/prerender-error
Error: Unable to find `TinaProvider`; did you forget to add the TinaCMS container to your app root?  See our setup docs: https://tina.io/docs/introduction/tina-init/#adding-tina

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minhdna I just updated again to the latest version of Tina and updated to the latest master. The /admin/[...tina] file was delete are you sure you are deploying from my fork using the correct branch?

It would be really nice to get this merged as we are getting folks asking about tina being broken on this site.

Thanks again for looking at this 😄

@haoxuw
Copy link

haoxuw commented Aug 13, 2023

Hello folks, amazing work!
@logan-anderson @bmstefanski
Wondering if we could continue on this thread and get this official fix merged. Otherwise users would potentially have to deal with conflicts when writing fixes on their fork

Thanks for the great work!

@arielmirra
Copy link

Hello again @logan-anderson and @bmstefanski! Thank you for this fix! i'd really love for this to be merged so I can use this beautiful template, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants