Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcade Account Improvements #543

Merged
merged 24 commits into from
Mar 23, 2024
Merged

Arcade Account Improvements #543

merged 24 commits into from
Mar 23, 2024

Conversation

starknetdev
Copy link
Contributor

No description provided.

* - implement new import AA screen
- implement export private key button on arcade accounts

* - finish check if arcade already stored

* - fix overflow scrolling

* clean
* - add minting lords screen
- add check that it can't be an arcade

* - remove need for connecting wallet
- fix mint LORDS from AA (add permission)
- implement fetch for supports interface

* - fix blocking arcades on lords mint

* fix build
Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
loot-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 11:38am

@starknetdev starknetdev changed the title Arcade Account Imrpovements Arcade Account Improvements Jan 29, 2024
- Adventurer Workaround: don't drop any items until you have full inventory 19/19
- Client Recommendation: don't let player drop any items until they have full inventory 19/19
- Every item dropped before 19/19 will result in an unusable inventory slot
@ponderingdemocritus
Copy link
Contributor

havent tested - but looks logical

@ponderingdemocritus
Copy link
Contributor

@starknetdev - should we merge this?

* Adventurer max level increases from 90 to 127
* Adventurer max strength and vitality increases from 15 to 31

---------

Co-authored-by: loothero <[email protected]>
* fixes failing tests in game entropy library
* updates readme to be consistent with latest contract
* updates repo to use starkli instead of legacy starknet
* adds script to automate starkli account setup
* adds script to automate contract deployment
* adds DockerFile
* on v1.0.0 the idle counter is reset on every attack
* adventurers can exploit this during certain battles to significantly prolong the duration of the battle which weakens the protection provided by the idle death penalty and global entropy sub-systems
This reverts commit c8f3c25.
* allows clients to optimistically provide contract with the block hash for start_block + 1
* contract will verify provided hash was correct as part of highscore check and prior to minting collectible beast
* contract provides a public slay_invalid_adventurers that can be used to slay adventurers started with wrong hash
* this change is backwards compatible with existing clients. Calling attack() after 11 blocks will work same as it did previously but now clients can call set_starting_entropy(adventurer_id, block_hash) when start_block + 1 hash is available and proceed to call attack() immediately after.
* fixes quantum entanglement bug (metadata sharing)
* includes test case for reproducing QE bug
* includes test case for reproducing unusable inventory slots 
* includes additional test cases for stress testing inventory/metadata (temp commented out)
* hard codes contract genesis timestamp to V1.0 contract
* this can be removed after v1.1 optimistic start feature iis vetted on Sepolia
* this can be reverted after v1.1 optimistic start feature is vetted on Sepolia.
- fix type issues
@ponderingdemocritus ponderingdemocritus merged commit 000d10e into production Mar 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants