Add support for pair/triple selecting in condp #2998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the growSelection function to support:
- Test/result pairs in condp forms (e.g., condp = x 1 "one" 2 "two")
- Test :>> function triples in condp (e.g., condp some [1 2] #{0 6} :>> inc)
- Default values (odd element at the end is not paired)
This allows users to expand selections correctly when working with
condp conditional expressions, improving the editing experience in Calva.
Known limitation: There is a bug (also affecting case forms) where
selecting the first element of a pair and growing the selection causes
it to jump backward to the test expression instead of forward to include
the pair. This needs further investigation of the rangesForSexpsInList()
behavior. The main use case (selecting the second element first) works
correctly.
Fixes BetterThanTomorrow#2995
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
Implemented pair/triple selecting in
condpforms, allowing users to expand selections to include entire test/result pairs and test:>>function triples.Fixes #2995
My Calva PR Checklist
I have:
devbranch. (Or have specific reasons to target some other branch.)published. (Sorry for the nagging.)[Unreleased]entry inCHANGELOG.md, linking the issue(s) that the PR is addressing.npm run prettier-format)npm run eslintbefore creating your PR, or runnpm run eslint-watchto eslint as you go).