Add support for growing selection in case forms #2997
+145
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the growSelection function to consider value/result pairs in `case` forms. This allows users to expand selections correctly when working with conditional expressions, improving the editing experience in Calva. Fixes BetterThanTomorrow#2993
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This change introduces a new test case to verify that the selection grows correctly to value/result pairs in case statements when the value is selected first. This ensures the functionality works as intended for different selection scenarios in case forms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
This PR adds support for growing selection to consider value/result pairs in
caseforms, similar to how it works forcondand binding forms likelet.src/cursor-doc/paredit.tsto includecasein conditional forms with correct offset handling (pairs start after function name and initial form).src/extension-test/unit/cursor-doc/paredit-test.tsfor pair selecting incaseforms.CHANGELOG.mdwith an enhancement entry linking to issue Pair selecting in case #2993.test-data/test-files/paredit_sandbox.cljfor the new forms.Fixes #2993
My Calva PR Checklist
I have:
devbranch. (Or have specific reasons to target some other branch.)published. (Sorry for the nagging.)[Unreleased]entry inCHANGELOG.md, linking the issue(s) that the PR is addressing.npm run prettier-format)npm run eslintbefore creating your PR, or runnpm run eslint-watchto eslint as you go).