Show better_errors even when using Turbo
#526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've enjoyed using Turbo in my Ruby projects. What I haven't loved is the opaque `Content Missing` error that pops up when a Turbo-wrapped request throws an error. Sure, I can right-click and dig into the request panel on my developer tools; and I do... But wouldn't it be nice if instead of all that nonsense; errors would render directly to the screen; so I can read them with my lazy eyeballs rather than having to use my clicky-clicky-fingers? Anway, this adds [a header to the better errors layout](https://turbo.hotwired.dev/reference/attributes#meta-tags) which tells turbo exactly where to shove the content of this error page. Right up our eyeballs.
rosschapman
approved these changes
Dec 21, 2023
|
This project has been dropped ? |
|
Dear maintainers, can this PR be merged please? |
|
Should this perhaps be only added for GET requests? Otherwise when a POST form submission raises an error it'll just re-fetch the page as a GET, won't it? |
|
I hope you are doing well. Thank you for all the hard work you’ve put into maintaining this gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've enjoyed using Turbo in my Ruby projects. What I haven't loved is the opaque
Content Missingerror that pops up when a Turbo-wrapped request throws an error.Sure, I can right-click and dig into the request panel on my developer tools; and I do...
But wouldn't it be nice if instead of all that nonsense; errors would render directly to the screen; so I can read them with my lazy eyeballs rather than having to use my clicky-clicky-fingers?
Anway, this adds a header to the better errors
layout which tells turbo exactly where to shove the content of this error page.
Right up our eyeballs.