Skip to content

Commit

Permalink
LibJS: Add missing ValueInlines.h include for Value::to_numeric
Browse files Browse the repository at this point in the history
When compiling with `-O2 -g1` optimizations (as done in the main
Serenity build), no out-of-line definitions end up emitted for
`Value::to_numeric`, causing files that reference the function but don't
include the definition from `ValueInlines.h` to add an undefined
reference in LibJS.so.
  • Loading branch information
BertalanD committed Jul 7, 2024
1 parent 00029e0 commit 85b7ce8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Userland/Libraries/LibJS/Runtime/NumberConstructor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include <LibJS/Runtime/GlobalObject.h>
#include <LibJS/Runtime/NumberConstructor.h>
#include <LibJS/Runtime/NumberObject.h>
#include <LibJS/Runtime/ValueInlines.h>

#if defined(AK_COMPILER_CLANG)
# define EPSILON_VALUE AK::exp2(-52.)
Expand Down

0 comments on commit 85b7ce8

Please sign in to comment.