AzureAD Default credentials - select credential type based on environment #14470
+173
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l type from env var don't default to ClientSecretCredential unless present in env var
…fault azure credentials used in the right context
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| or infer_credential_type_from_environment() | ||
| ) | ||
| verbose_logger.info( | ||
| f"For Azure AD Token Provider, choosing credential type: {cred}" |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
The best way to fix the issue is to ensure that no potentially sensitive credential information, including types that indicate secret material is present, are logged in clear text.
- We should remove or minimize the logging of which credential type is chosen from the line:
verbose_logger.info(f"For Azure AD Token Provider, choosing credential type: {cred}") - If some logging is still desired for operational awareness, it should be redacted or limited (e.g., logging only that a credential was chosen, not the specific type), or log only if a safe setting is explicitly enabled.
- Change: in
litellm/secret_managers/get_azure_ad_token_provider.py, remove or replace line 76-78 so it does not log the value of the credential type.- Option 1: Remove the line entirely.
- Option 2 (if you want to keep some logging): Replace it with a minimal, non-sensitive log such as "Azure AD Token Provider credential type chosen" (no actual value shown).
- No new imports or methods are needed.
Suggested changeset
1
litellm/secret_managers/get_azure_ad_token_provider.py
| @@ -73,9 +73,7 @@ | ||
| or os.environ.get("AZURE_CREDENTIAL") | ||
| or infer_credential_type_from_environment() | ||
| ) | ||
| verbose_logger.info( | ||
| f"For Azure AD Token Provider, choosing credential type: {cred}" | ||
| ) | ||
| # Do not log credential type to avoid disclosing sensitive information. | ||
| credential: Optional[ | ||
| Union[ | ||
| ClientSecretCredential, |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes